mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marco Massenzio" <ma...@mesosphere.io>
Subject Re: Review Request 37336: Simplified the caller interface to process::Subprocess
Date Mon, 02 Nov 2015 07:22:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37336/
-----------------------------------------------------------

(Updated Nov. 2, 2015, 7:22 a.m.)


Review request for mesos, Joris Van Remoortere and Michael Park.


Bugs: MESOS-3035
    https://issues.apache.org/jira/browse/MESOS-3035


Repository: mesos


Description
-------

Jira: MESOS-3035

    The original API for `process::Subprocess` still left a lot of legwork
    to do for the caller; we have now added an `execute()` method
    that returns a `Future<CommandResult>` (also introduced with this patch) which
    contains useful information about the command invocation; the exit code;
    stdout and, optionally, stderr too.
    
    Once the Future completes, if successful, the caller will be able to retrieve
    stdout/stderr; whether the command was successful; and whether it received a signal


Diffs (updated)
-----

  3rdparty/libprocess/include/process/subprocess.hpp f17816e813d5efce1d3bb1ff1e1111850eeda3ba

  3rdparty/libprocess/src/subprocess.cpp 459825c188d56d25f6e2832e5a170d806e257d6b 
  3rdparty/libprocess/src/tests/subprocess_tests.cpp ac600a551fb1a7782ff33cce204b7819497ef54a


Diff: https://reviews.apache.org/r/37336/diff/


Testing
-------

make check


Thanks,

Marco Massenzio


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message