mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guangya Liu" <gyliu...@gmail.com>
Subject Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.
Date Mon, 02 Nov 2015 10:17:05 GMT


> On Oct. 25, 2015, 1:39 p.m., Guangya Liu wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 1035
> > <https://reviews.apache.org/r/39401/diff/5/?file=1105060#file1105060line1035>
> >
> >     I know that we have design to exclue the reserved resource from quota, but why
not include the current role's reserved as available?
> 
> Alexander Rukletsov wrote:
>     If you mean dynamically reserved resources than yes, we can do that. If you mean
statically reserved than nope, we decided not to conflate them with quota.
> 
> Guangya Liu wrote:
>     I mean both static and dynamic reservation, I think that both of the reservations
for one role should be included in the role's quota, can you pleaes clairify why not include
static reservation in one role's quota?
> 
> Alexander Rukletsov wrote:
>     Does [this](https://docs.google.com/document/d/16iRNmziasEjVOblYp5bbkeBZ7pnjNlaIzPQqMTHQ-9I/edit?pli=1#heading=h.xumvch9xiky2)
answer your question?

I see that the design document want to use the last one "Static reservations are static (implicit)
part of quota, operators cannot change them via quota mechanisms.", my understanding is that
the static reservations will be treated as the implicit part of quota, right?


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39401/#review103954
-----------------------------------------------------------


On Oct. 29, 2015, 7:29 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39401/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2015, 7:29 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3718
>     https://issues.apache.org/jira/browse/MESOS-3718
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp f4e4a123d3da0442e8b0b0ad14d1ee760752ba36

> 
> Diff: https://reviews.apache.org/r/39401/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message