mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joerg Schad" <jo...@mesosphere.io>
Subject Re: Review Request 39285: Added Quota Request Validation.
Date Mon, 02 Nov 2015 16:25:03 GMT


> On Oct. 25, 2015, 2:45 a.m., Klaus Ma wrote:
> > src/master/master.hpp, line 864
> > <https://reviews.apache.org/r/39285/diff/6/?file=1105158#file1105158line864>
> >
> >     Should we return Bad Request (404) for now, because we did not implement it
yet.

As it is implemented in the following patches it does not matter too much in my opinion...


> On Oct. 25, 2015, 2:45 a.m., Klaus Ma wrote:
> > src/master/master.hpp, line 875
> > <https://reviews.apache.org/r/39285/diff/6/?file=1105158#file1105158line875>
> >
> >     Same as above.

see above...


- Joerg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/#review103918
-----------------------------------------------------------


On Oct. 24, 2015, 7:42 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39285/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2015, 7:42 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3199
>     https://issues.apache.org/jira/browse/MESOS-3199
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added Quota Request Validation.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39285/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message