mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.
Date Mon, 02 Nov 2015 22:57:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39803/#review104810
-----------------------------------------------------------


Partial review.  (Haven't looked at the new files yet).

`stat.hpp` looks mostly fine to me.


3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp (line 17)
<https://reviews.apache.org/r/39803/#comment163054>

    Is this necessary?



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp (line 21)
<https://reviews.apache.org/r/39803/#comment163055>

    This appears to be unused.



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp (line 26)
<https://reviews.apache.org/r/39803/#comment163058>

    This appears to be unused.



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp (line 144)
<https://reviews.apache.org/r/39803/#comment163053>

    I think we still need an `rdev` function.  (Although it'll have to be some sort of no-op
on Windows.)


- Joseph Wu


On Oct. 31, 2015, 6:31 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39803/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2015, 6:31 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere,
and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Implemented stout/os/stat.hpp`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 67b142bbc2d80f40a1e893cc5813d58dd2aa8381

>   3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp
PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/symlink.hpp PRE-CREATION

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp 675b2e712358a55b3580026936890eaf80e5af71

>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 1a7037d64afeedc340258c92067e95d1d3caa027

> 
> Diff: https://reviews.apache.org/r/39803/diff/
> 
> 
> Testing
> -------
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message