mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 39719: Fixed marking mounts as slave in ubuntu.
Date Tue, 03 Nov 2015 16:48:14 GMT


> On Nov. 3, 2015, 1:01 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/mark_mounts_rslave.hpp, line 36
> > <https://reviews.apache.org/r/39719/diff/4/?file=1114129#file1114129line36>
> >
> >     I am thinking about making this more general and can be extended in case we
need to (e.g., supporting make-slave, make-rshared, or other mount operation).
> >     
> >     How about calling this Subcommand:
> >     `MesosContainerizerMount`
> >     
> >     ```
> >     class MesosContainerizerMount : public Subcommand
> >     {
> >     public:
> >       static constexpr char NAME[] = ""
> >       static constexpr char MAKE_RSLAVE[] = "make-rslave";
> >       
> >       struct Flags : public flags:: FlagsBase
> >       {
> >         Flags();
> >         
> >         std::string operation;
> >         Option<std::string> path;
> >       };
> >     };
> >     
> >     int MesosContainerizerMount::execute()
> >     {
> >       if (flags.operation == MAKE_RSLAVE) {
> >         if (flags.path.isNone()) {
> >           ..
> >         }
> >         
> >         fs::mount(...);
> >       } else {
> >         cerr << "Unknown operation: " << flags.operation;
> >         return 1;
> >       }
> >     }
> >     ```

Sure, I wasn't sure if we need to support all kinds of mounts but I'll leave that option open
by putting the code like you suggested.


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39719/#review104835
-----------------------------------------------------------


On Nov. 2, 2015, 6:52 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39719/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2015, 6:52 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-3806
>     https://issues.apache.org/jira/browse/MESOS-3806
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed marking mounts as slave in ubuntu. More details please see MESOS-3806
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp a126cd6ee15adb8d92e85ab562e998e3647f999a

>   src/slave/containerizer/mesos/main.cpp 0e1793128b56ab2e0aa2d263383c9de47ffe25d1 
>   src/slave/containerizer/mesos/mark_mounts_rslave.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/mark_mounts_rslave.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39719/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message