mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 39804: Windows: Moved `os::find` to its own file, `stout/os/find.hpp`.
Date Wed, 04 Nov 2015 21:50:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39804/#review105146
-----------------------------------------------------------

Ship it!


Checked that code did not change in midst of the move.


3rdparty/libprocess/3rdparty/stout/include/stout/os/find.hpp (line 16)
<https://reviews.apache.org/r/39804/#comment163554>

    ```
    #include <list>
    #include <string>
    
    #include <stout/error.hpp>
    ```



3rdparty/libprocess/3rdparty/stout/include/stout/os/find.hpp (line 50)
<https://reviews.apache.org/r/39804/#comment163557>

    This was originally present, but you can remove the space between the `> >`.


- Joseph Wu


On Oct. 31, 2015, 5:28 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39804/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2015, 5:28 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere,
and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Moved `os::find` to its own file, `stout/os/find.hpp`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 67b142bbc2d80f40a1e893cc5813d58dd2aa8381

>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp fc2df6831ae2cb1a91c7a8cc92965939576e575d

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/find.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39804/diff/
> 
> 
> Testing
> -------
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message