mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 39834: Made `path_tests.cpp` standalone.
Date Wed, 04 Nov 2015 22:01:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39834/#review105150
-----------------------------------------------------------

Ship it!



3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp (lines 21 - 22)
<https://reviews.apache.org/r/39834/#comment163563>

    You might also want `<stout/os/exists.hpp>`, `<stout/os/open.hpp`>, and `<stout/os/getcwd.hpp>`.


- Joseph Wu


On Nov. 2, 2015, 10:36 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39834/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2015, 10:36 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere,
and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made `path_tests.cpp` standalone.
> 
> NB, more of these tests will move when `Hopcroft` is done with his `os::symlink` changeset.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp ad9ce324eaf940f68d04c6db7ba37d05efb1216a

> 
> Diff: https://reviews.apache.org/r/39834/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message