mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jojy Varghese" <j...@mesosphere.io>
Subject Re: Review Request 39840: RegistryClient refactor: pulled up streaming read
Date Thu, 05 Nov 2015 21:05:07 GMT


> On Nov. 5, 2015, 8:38 p.m., Timothy Chen wrote:
> > I don't see why we need this commit from the previos one. Can we merge this with
the last one?

The reason being that the changes here are significant. We can merge the two if you think.


- Jojy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39840/#review105303
-----------------------------------------------------------


On Nov. 5, 2015, 4:02 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39840/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2015, 4:02 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made reading the stream from the PIPE common.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c

> 
> Diff: https://reviews.apache.org/r/39840/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message