mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 39340: RegistryClient: Added streaming response read
Date Fri, 06 Nov 2015 07:12:23 GMT


> On Nov. 6, 2015, 4:56 a.m., Timothy Chen wrote:
> > src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp, line 637
> > <https://reviews.apache.org/r/39340/diff/11/?file=1117487#file1117487line637>
> >
> >     But we're not modifying totalSize at all, only use it to create a new variable
on the stack.
> >     
> >     Let me try it locally.

Ok just confirmed this works: https://gist.github.com/tnachen/990b1b0bb0c9e7f8d23c
No need for mutable.


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39340/#review105361
-----------------------------------------------------------


On Nov. 6, 2015, 12:38 a.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39340/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2015, 12:38 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> RegistryClient: Added streaming response read
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c

> 
> Diff: https://reviews.apache.org/r/39340/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message