mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 39886: Added documentation about roles.
Date Fri, 06 Nov 2015 09:25:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39886/#review105393
-----------------------------------------------------------

Ship it!


Remove the unrelated configuration.md changes and I'll commit this.


docs/configuration.md (line 50)
<https://reviews.apache.org/r/39886/#comment163979>

    If you're changing the flag descriptions in configuration.md, you should also be changing
the command-line --help strings in the flags.cpp's.
    
    Please remove these unrelated changes for now. We can address them in a separate patch
along with their command-line --help's.



docs/home.md (line 19)
<https://reviews.apache.org/r/39886/#comment163980>

    If we're not doing alphabetical, I would either put this under Configuration, under "Attributes
and Resources", or just before Reservation.



docs/roles.md (line 79)
<https://reviews.apache.org/r/39886/#comment163982>

    More accurately: "... will be allocated twice the fair share of a role with a weight of
1."
    We cannot guarantee the exact offer ratio, depending on fair-share usage, available resources,
reservations, filters, etc.


- Adam B


On Nov. 5, 2015, 9:42 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39886/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2015, 9:42 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-3819
>     https://issues.apache.org/jira/browse/MESOS-3819
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Also removed a redundant (and arguably slightly wrong) assertion about the
> status of static reservations.
> 
> 
> Diffs
> -----
> 
>   docs/attributes-resources.md f712d094f14426515dabde45f98d6c1ae36c3447 
>   docs/authorization.md 2a5e74782754e446184a297f91112e9f94077896 
>   docs/configuration.md 195814cf918e018d8287113299163415b94ab09f 
>   docs/home.md af886257348f24cfeecfc726255d8d45d68af2db 
>   docs/reservation.md 69bde760ece59c68b04a903026b5903e2091ceb0 
>   docs/roles.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39886/diff/
> 
> 
> Testing
> -------
> 
> Previewed with the support/site Docker container.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message