mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Klaus Ma" <klaus1982...@gmail.com>
Subject Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.
Date Fri, 06 Nov 2015 15:06:07 GMT


> On Oct. 25, 2015, 8:10 a.m., Klaus Ma wrote:
> > include/mesos/master/allocator.hpp, line 358
> > <https://reviews.apache.org/r/38218/diff/7/?file=1105051#file1105051line358>
> >
> >     It said Mesos master will also validate the quota request in design document;
should we clarify which part is covered by Mesos master and which part should be covered by
allocator? For example, according to this comments, empty role will pass master's checking;
it's allocator's resposibility to accept or reject it.
> 
> Alexander Rukletsov wrote:
>     A hard thing here is to specify, what a *custom* allocator should check. I try to
impose as few restrictions as possible. The part of the comment you refer to says that if
an internal invariant (double `setQuota()` call) is violated.

That's OK to me :).


- Klaus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38218/#review103910
-----------------------------------------------------------


On Nov. 6, 2015, 3:29 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38218/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2015, 3:29 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, and Joseph
Wu.
> 
> 
> Bugs: MESOS-3716
>     https://issues.apache.org/jira/browse/MESOS-3716
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611 
>   src/master/allocator/mesos/allocator.hpp c5375aa89b210e46c41ac7d68d119749de15d2f5 
>   src/master/allocator/mesos/hierarchical.hpp cfd937ba306273c24fb5337dfeb1a15e1545169b

>   src/master/allocator/mesos/hierarchical.cpp f4e4a123d3da0442e8b0b0ad14d1ee760752ba36

>   src/tests/mesos.hpp 3e58b454c75a2ab9f8b4a29785fa823afefd0c8a 
> 
> Diff: https://reviews.apache.org/r/38218/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message