mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Klaus Ma" <klaus1982...@gmail.com>
Subject Re: Review Request 39285: Added Quota Request Validation.
Date Fri, 06 Nov 2015 16:19:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/#review105440
-----------------------------------------------------------



src/master/quota_handler.cpp (line 113)
<https://reviews.apache.org/r/39285/#comment164041>

    Should we also check whether `resource.get().role()` is empty? There should be the case
that assign empty string to `resource.role`.



src/master/quota_handler.cpp (line 124)
<https://reviews.apache.org/r/39285/#comment164043>

    I'd suggest to move it before checking role to make all simple check together, i.e. `has_disk`,
`has_revocable`.



src/master/quota_handler.cpp (line 134)
<https://reviews.apache.org/r/39285/#comment164044>

    Suggest to move it into the loop; if any role is not known by master, we did not need
to continue to check others.



src/master/quota_handler.cpp (line 174)
<https://reviews.apache.org/r/39285/#comment164046>

    Should we move it into `validateQuotaRequest`? If any role is exist in master, we did
not need to continue to check others. And in QuotaHandler, we had the pointer to master `Master*
master`.


- Klaus Ma


On Nov. 6, 2015, 11:23 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39285/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2015, 11:23 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3199
>     https://issues.apache.org/jira/browse/MESOS-3199
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added Quota Request Validation.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp b76d30197b3decda0a742e03ce01a17a64b633ac 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39285/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message