mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 39340: RegistryClient: Added streaming response read
Date Fri, 06 Nov 2015 16:29:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39340/#review105448
-----------------------------------------------------------



src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 712)
<https://reviews.apache.org/r/39340/#comment164054>

    Let's not ignore the error for os::close().
    
    Please log when you cannot close the fd and the error.



src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 724)
<https://reviews.apache.org/r/39340/#comment164055>

    Also please include that the future is discarded the failure message.


- Timothy Chen


On Nov. 6, 2015, 3:50 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39340/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2015, 3:50 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> RegistryClient: Added streaming response read
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c

> 
> Diff: https://reviews.apache.org/r/39340/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message