mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.
Date Sun, 08 Nov 2015 22:32:51 GMT


> On Nov. 2, 2015, 2:22 p.m., Joerg Schad wrote:
> > src/master/allocator/mesos/allocator.hpp, line 268
> > <https://reviews.apache.org/r/38218/diff/7/?file=1105052#file1105052line268>
> >
> >     Could we add a todo for updateQuota()? In my opinion this would make it easier
to understand both the MVP semantic as well as the post mvp plans. Same below.

I'm not sure we plan a triad `set`, `update`, `remove` is an agreed design for the post MVP.
I can envision the situation we agree to use, say, `update` and `remove`. Hence I'm reluctant
to add a todo here.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38218/#review104710
-----------------------------------------------------------


On Nov. 5, 2015, 7:29 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38218/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2015, 7:29 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, and Joseph
Wu.
> 
> 
> Bugs: MESOS-3716
>     https://issues.apache.org/jira/browse/MESOS-3716
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611 
>   src/master/allocator/mesos/allocator.hpp c5375aa89b210e46c41ac7d68d119749de15d2f5 
>   src/master/allocator/mesos/hierarchical.hpp cfd937ba306273c24fb5337dfeb1a15e1545169b

>   src/master/allocator/mesos/hierarchical.cpp f4e4a123d3da0442e8b0b0ad14d1ee760752ba36

>   src/tests/mesos.hpp 3e58b454c75a2ab9f8b4a29785fa823afefd0c8a 
> 
> Diff: https://reviews.apache.org/r/38218/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message