mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 39285: Added Quota Request Validation.
Date Sun, 08 Nov 2015 23:22:08 GMT


> On Nov. 6, 2015, 4:19 p.m., Klaus Ma wrote:
> > src/master/quota_handler.cpp, line 119
> > <https://reviews.apache.org/r/39285/diff/7/?file=1118136#file1118136line119>
> >
> >     Should we also check whether `resource.get().role()` is empty? There should
be the case that assign empty string to `resource.role`.

Do we explicitly prohibit empty roles?


> On Nov. 6, 2015, 4:19 p.m., Klaus Ma wrote:
> > src/master/quota_handler.cpp, line 140
> > <https://reviews.apache.org/r/39285/diff/7/?file=1118136#file1118136line140>
> >
> >     Suggest to move it into the loop; if any role is not known by master, we did
not need to continue to check others.

I think the flow is more readable how it's now: in the loop we reconstruct the "reference"
role, afterwards we check whether it is known to the master. Also, my gut feeling is that
typos in roles will not be that frequent, so checking it once instead of per resource makes
sense to me.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/#review105440
-----------------------------------------------------------


On Nov. 6, 2015, 3:23 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39285/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2015, 3:23 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3199
>     https://issues.apache.org/jira/browse/MESOS-3199
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added Quota Request Validation.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp b76d30197b3decda0a742e03ce01a17a64b633ac 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39285/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message