mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joerg Schad" <jo...@mesosphere.io>
Subject Re: Review Request 39450: Quota: Added hierarchical allocator-specific tests.
Date Tue, 10 Nov 2015 16:03:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39450/#review105885
-----------------------------------------------------------



src/tests/hierarchical_allocator_tests.cpp (line 1150)
<https://reviews.apache.org/r/39450/#comment164577>

    Also the simple case of correct behavior with several frameworks in one role would be
interesting.



src/tests/hierarchical_allocator_tests.cpp (line 1173)
<https://reviews.apache.org/r/39450/#comment164571>

    Does it make sense to refelect that in the role name?



src/tests/hierarchical_allocator_tests.cpp (line 1618)
<https://reviews.apache.org/r/39450/#comment164574>

    This describes more the user story, should we maybe focus on what the test itself intends
to test?


- Joerg Schad


On Nov. 5, 2015, 6:26 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39450/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2015, 6:26 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, and Joseph
Wu.
> 
> 
> Bugs: MESOS-3718
>     https://issues.apache.org/jira/browse/MESOS-3718
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp 505b9de3d8d888c296f6103c80fe9f0ef1c2ca16

> 
> Diff: https://reviews.apache.org/r/39450/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message