mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 39695: Relocate launcher and linux_launcher as MesosContainerizer specific
Date Wed, 11 Nov 2015 18:49:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39695/#review106124
-----------------------------------------------------------



src/CMakeLists.txt (lines 198 - 199)
<https://reviews.apache.org/r/39695/#comment164828>

    Please move this up right below slave/containerizer/mesos/containerizer.cpp



src/Makefile.am (lines 548 - 549)
<https://reviews.apache.org/r/39695/#comment164827>

    Please move this up right after 'slave/containerizer/mesos/containerizer.cpp'



src/slave/containerizer/containerizer.cpp (lines 37 - 39)
<https://reviews.apache.org/r/39695/#comment164826>

    Please move this down.



src/slave/containerizer/containerizer.cpp (lines 44 - 46)
<https://reviews.apache.org/r/39695/#comment164825>

    Please group them together and sort them accordingly.



src/slave/containerizer/external_containerizer.hpp (line 37)
<https://reviews.apache.org/r/39695/#comment164824>

    Add a new line above.



src/slave/containerizer/mesos/containerizer.hpp (line 35)
<https://reviews.apache.org/r/39695/#comment164823>

    Add a new line above.



src/slave/containerizer/mesos/containerizer.cpp (line 45)
<https://reviews.apache.org/r/39695/#comment164821>

    Add a new line above.



src/tests/containerizer/mesos_containerizer_tests.cpp (lines 39 - 41)
<https://reviews.apache.org/r/39695/#comment164820>

    Please group them together and sort them accordingly.



src/tests/containerizer/port_mapping_tests.cpp (lines 62 - 66)
<https://reviews.apache.org/r/39695/#comment164819>

    Please group them together and sort them in alphebet order.


- Jie Yu


On Oct. 29, 2015, 12:11 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39695/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2015, 12:11 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-3129
>     https://issues.apache.org/jira/browse/MESOS-3129
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Relocate launcher and linux_launcher as MesosContainerizer specific
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt d107e329cc6887cd9d4ce3706dfc6ce6080d0289 
>   src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db 
>   src/slave/containerizer/containerizer.cpp 06753365e2ec7cb59edd1ed6ecfe1a794498ee9b

>   src/slave/containerizer/external_containerizer.hpp c00cebb93c5395bccbef558632d8f9c9bee8fffa

>   src/slave/containerizer/launcher.hpp  
>   src/slave/containerizer/launcher.cpp 668ae80d0723068f85f7c16e0cc57804bb55af16 
>   src/slave/containerizer/linux_launcher.hpp 627df892728f127f37672991e1a57ee445008fe1

>   src/slave/containerizer/linux_launcher.cpp c0adb34771fdb5a85d087296a8f98b890254ddf7

>   src/slave/containerizer/mesos/containerizer.hpp 4aad8a3be43b331efc6b8157b2fae090df16c1b4

>   src/slave/containerizer/mesos/containerizer.cpp 91e4ea3a907ad165c359e7422135138737e14085

>   src/tests/containerizer/filesystem_isolator_tests.cpp 39008f6201777783d242407fea5377bfceffc57b

>   src/tests/containerizer/isolator_tests.cpp 4e1e90ba2aeb70d4a70c3e0cf9796bd1aa199147

>   src/tests/containerizer/launcher.hpp 5d34bab789bdafe71d94e8ec263710c50b83e180 
>   src/tests/containerizer/mesos_containerizer_tests.cpp b48133c3d0624b27bcdc2289669c7f0b1bcc12f4

>   src/tests/containerizer/port_mapping_tests.cpp ae2c0e613acf41614413e41e6989e9056328ff36

> 
> Diff: https://reviews.apache.org/r/39695/diff/
> 
> 
> Testing
> -------
> 
> make check (Ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message