mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 39285: Added Quota Request Validation.
Date Fri, 13 Nov 2015 16:21:33 GMT


> On Nov. 13, 2015, 12:03 p.m., Alexander Rukletsov wrote:
> > src/master/quota_handler.cpp, lines 95-102
> > <https://reviews.apache.org/r/39285/diff/22/?file=1124292#file1124292line95>
> >
> >     Not your fault, but here is one thing that bothers me a bit.
> >     
> >     It looks like we are inconsistent about what we expect for operator endpoints.
For example, dynamic reservations take a string "slaveId=<JSON>&resources=<JSON>",
while maintenance expect "<JSON>" directly.
> >     
> >     I would like us to be more consistent on this. Shall we create a clean-up ticket?

https://issues.apache.org/jira/browse/MESOS-3914


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/#review106402
-----------------------------------------------------------


On Nov. 12, 2015, 3:21 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39285/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2015, 3:21 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3199
>     https://issues.apache.org/jira/browse/MESOS-3199
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added Quota Request Validation.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/quota.hpp PRE-CREATION 
>   src/master/quota.cpp PRE-CREATION 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39285/diff/
> 
> 
> Testing
> -------
> 
> make test
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message