mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 39852: Windows: Replaced global `GetMessage` macro with inline function.
Date Tue, 17 Nov 2015 20:06:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39852/#review106927
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp (lines 58 - 66)
<https://reviews.apache.org/r/39852/#comment165735>

    I'm wondering what the alternatives are.
    
    `GetMessage` seems to be some sort of alias for `GetMessageA` or `GetMessageW`.  What
would happen if we just used the A/W methods instead?
    
    Do we even need to redefine this?  Would anything break if we just `#undef` d it?


- Joseph Wu


On Nov. 16, 2015, 1:15 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39852/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2015, 1:15 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere,
and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Replaced global `GetMessage` macro with inline function.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 1a7037d64afeedc340258c92067e95d1d3caa027

> 
> Diff: https://reviews.apache.org/r/39852/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message