mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Clemmer" <clemmer.alexan...@gmail.com>
Subject Re: Review Request 40114: Windows: Began adding Windows support to `process/future.hpp`
Date Mon, 23 Nov 2015 18:11:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40114/#review107619
-----------------------------------------------------------

Ship it!


Looks good, couple minor comments. Can you please also add the following people to the review:
`hartem` (Artem, Mesos-core dev manager), `jvanremoortere` (Mesos committer), `kaysoky` (Mesos
core team member), `mcypark` (Mesos committer, with fancy SFINAE knowledge).


3rdparty/libprocess/include/process/future.hpp (line 355)
<https://reviews.apache.org/r/40114/#comment166849>

    Please add TODO here for me also.



3rdparty/libprocess/include/process/future.hpp (line 187)
<https://reviews.apache.org/r/40114/#comment166847>

    Oh, I see, we are expecting to update this in February. Can you add a `TODO(hausdorff)`
to tell me to update this in February? Also can you please mention this issue is tracked in
issue MESOS-3993?



3rdparty/libprocess/include/process/future.hpp (line 237)
<https://reviews.apache.org/r/40114/#comment166848>

    Sorry, one more thing. How about something like "Platform-dependent template in this macro
are equivalent to:"
    
    This just makes it very clear what the relationship of the commented-out template is.
Otherwise people might think that the template was commented out and is just dead code. (We
wouldn't want someone to do a style-pass and delete it accidentally!)


- Alex Clemmer


On Nov. 21, 2015, 1:47 a.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40114/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2015, 1:47 a.m.)
> 
> 
> Review request for mesos and Alex Clemmer.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added Windows & Posix defines for several parameter list used in future.hpp. 
> Provided a new parameter list for VC2015.
> Move the existing parameter list into posix.hpp. 
> 
> The change has been due to: 
> 
>    1. VS 2015 won't support C++14 result_of SFINAE until Update 2,  so
>       result_of must be replaced with decltype(invoke).
>    2. VS 2015 won't support C++14 std::function SFINAE until Update 2, so
>       converting _Deferred to std::function must be done by explicitly
>       calling _Deferred's conversion function.
>    3. The Standard (C++11 through 17) does not require bind's function call
>       operator to SFINAE, and VS 2015's doesn't.  is_bind_expression can be
>       used to manually reroute bind expressions to the 1-arg overload, where
>       (conveniently) the argument will be ignored if necessary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/future.hpp 3916150691e9a0880b8b826734fa74bd33d18cfd

>   3rdparty/libprocess/include/process/posix/future.hpp PRE-CREATION 
>   3rdparty/libprocess/include/process/windows/future.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40114/diff/
> 
> 
> Testing
> -------
> 
> OSX make check, Windows 10 make, Ubuntu 15.1 make check
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message