mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jan Schlicht" <...@mesosphere.io>
Subject Re: Review Request 41550: Quota: Added tests for quota removal authorization.
Date Wed, 06 Jan 2016 14:37:01 GMT


> On Jan. 6, 2016, 2:54 p.m., Alexander Rukletsov wrote:
> > src/tests/master_quota_tests.cpp, line 1243
> > <https://reviews.apache.org/r/41550/diff/5-6/?file=1184043#file1184043line1243>
> >
> >     There is no agent any more, right : )? How about
> >     "A request can contain any amount of resources because we set the force flag."

After some discussion we decided to also include an explanation what the rationale for using
the force flags has to do with these resources.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41550/#review113064
-----------------------------------------------------------


On Jan. 6, 2016, 3:34 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41550/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2016, 3:34 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Till Toenshoff.
> 
> 
> Bugs: MESOS-4083
>     https://issues.apache.org/jira/browse/MESOS-4083
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/authorization_tests.cpp 1d11a02032c142455debd9c78d4ee4cc6297a350 
>   src/tests/master_quota_tests.cpp 81f0386d072d0176cb28eb229b274e424004f54c 
> 
> Diff: https://reviews.apache.org/r/41550/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message