mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 42002: Updated missing allocator comments and removed redundancies.
Date Thu, 07 Jan 2016 01:58:39 GMT


> On Jan. 6, 2016, 5:48 p.m., Guangya Liu wrote:
> > include/mesos/master/allocator.hpp, line 73
> > <https://reviews.apache.org/r/42002/diff/1/?file=1185690#file1185690line73>
> >
> >     does this still needed?

Tweaked to:
   * Initializes the allocator when the master starts up. Any errors in
   * initialization should fail fast and result in an ABORT. The master expects
   * the allocator to be successfully initialized if this call returns.


- Adam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42002/#review113161
-----------------------------------------------------------


On Jan. 6, 2016, 4:47 p.m., Adam B wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42002/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2016, 4:47 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Guangya Liu, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated missing allocator comments and removed redundancies.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/allocator.hpp f7ada68d7111486d264284990996413bb33333d6 
> 
> Diff: https://reviews.apache.org/r/42002/diff/
> 
> 
> Testing
> -------
> 
> JAVADOC_AUTOBRIEF=YES means that the brief description stops at the first '.', so we
don't really need a newline or blank line in between brief and detailed descriptions.
> Also, REPEAT_BRIEF=YES means that the brief description is prepended to the detailed
description, so there's no need to repeat it ourselves.
> 
> I mostly wanted to get rid of gyliu513's TODOs, but got frustrated with the useless comment
: function definition ratio.
> 
> 
> Thanks,
> 
> Adam B
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message