mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 41593: Added `jsonify` function to stout.
Date Thu, 07 Jan 2016 10:25:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41593/#review113230
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/Makefile.am (line 38)
<https://reviews.apache.org/r/41593/#comment173729>

    Is formatting off or it's just review board?



3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp (lines 97 - 99)
<https://reviews.apache.org/r/41593/#comment173731>

    Why this behaviour? I would expect if `set()` is not called, nothing is printed. If a
field is optional, I can imagine some cases treating the absence of a value differently to
`false`, effectively implementing tribool logic.
    
    Or am I understanding the workflow wrong?



3rdparty/libprocess/3rdparty/stout/tests/jsonify_tests.cpp (lines 25 - 26)
<https://reviews.apache.org/r/41593/#comment173730>

    We have a good tradition to prepend each test with a comment explaining the purpose of
the test. Though it sometimes obvious without any comments, let's stick to this tradition
to avoid "broken windows".


- Alexander Rukletsov


On Jan. 5, 2016, 10:38 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41593/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 10:38 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 5ab7bc4966fe32eaddd573a4dbfd997f98b5d481

>   3rdparty/libprocess/3rdparty/stout/README.md a2a3dc6120b10c8fe82088b9f0ebecfa5642f945

>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe

>   3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 98ea47794b3a7c99b3cbd2418ba6e36eb5951259

>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 62ad461eb228b688f1ceac16cfb003561ed5a806

>   3rdparty/libprocess/3rdparty/stout/tests/jsonify_tests.cpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp bf2a2b8a9f67c6a4cf66b156b9c14fae015a8af0

> 
> Diff: https://reviews.apache.org/r/41593/diff/
> 
> 
> Testing
> -------
> 
> Added tests to `<stout/jsonify_tests.cpp>`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message