mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.
Date Thu, 07 Jan 2016 20:34:41 GMT


> On Dec. 30, 2015, 4:42 a.m., Klaus Ma wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 1321
> > <https://reviews.apache.org/r/40632/diff/8/?file=1178313#file1178313line1321>
> >
> >     As framework can not use ALLOCATION_SLACK mixed with other resources, allocator
need to check seperatly.
> 
> Guangya Liu wrote:
>     Yes, currently the validation logic in master is https://github.com/apache/mesos/blob/master/src/master/validation.cpp#L479-L488
which can make sure a task and its executor can either use non-revocable resources or revocable
resources of a given name but not both. After we introduced the allocation slack, we may want
to guard that a task and its executor can either use allocation slack or usage slack or non-revocable
resources but not all. I will upload a patch to handle this part.
> 
> Guangya Liu wrote:
>     Fixed in https://reviews.apache.org/r/41848/

Note: mixing resources is allowed.  Everything in a container is evicted at once, including
non-revocable resources mixed into a revocable one.


> On Dec. 30, 2015, 4:42 a.m., Klaus Ma wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 1334
> > <https://reviews.apache.org/r/40632/diff/8/?file=1178313#file1178313line1334>
> >
> >     In this check, it seems allocator send offer when both !allocation & allocation
are enough.

Looks like quota might have stepped on the toes of oversubscription.  I'll double-check with
Joris/AlexR.


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40632/#review112309
-----------------------------------------------------------


On Jan. 7, 2016, 3:27 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40632/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2016, 3:27 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph
Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-4145
>     https://issues.apache.org/jira/browse/MESOS-4145
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enabled oversubscribed resources for reservations in allocator.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f

>   src/tests/hierarchical_allocator_tests.cpp e044f832c2c16e53e663c6ced5452649bb0dcb59

> 
> Diff: https://reviews.apache.org/r/40632/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message