mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neil Conway" <neil.con...@gmail.com>
Subject Re: Review Request 42030: Added example of a `defer` bug to libprocess README.
Date Thu, 07 Jan 2016 23:21:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42030/#review113353
-----------------------------------------------------------



3rdparty/libprocess/README.md (line 247)
<https://reviews.apache.org/r/42030/#comment173900>

    We could simplify the wording a bit, I think: "It is instructive to examine ... One such
example."
    
    How about: "An example of a situation in which omitting `defer` lead to a bug can be found
in a (historical) version of `RegistryClientProcess::getBlob`:"



3rdparty/libprocess/README.md (line 253)
<https://reviews.apache.org/r/42030/#comment173899>

    Rather than including the full commit SHA1 in the text, can't we link to the appropriate
line number in the appropriate commit on Github?



3rdparty/libprocess/README.md (line 323)
<https://reviews.apache.org/r/42030/#comment173903>

    Do we really have to look at all the code paths within `doHttpGet`? By the time `getBlob()`
returns to the caller (i.e., by the time anyone might satisfy the future in question), `doHttpGet`
must have been called and returned already.


- Neil Conway


On Jan. 7, 2016, 7:46 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42030/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2016, 7:46 p.m.)
> 
> 
> Review request for mesos, Jojy Varghese, Neil Conway, and Timothy Chen.
> 
> 
> Bugs: MESOS-4207
>     https://issues.apache.org/jira/browse/MESOS-4207
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added example of a `defer` bug to libprocess README.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/README.md 6a47f6772bb7a74af368ed970af0f1c154a070e3 
> 
> Diff: https://reviews.apache.org/r/42030/diff/
> 
> 
> Testing
> -------
> 
> Viewed the markdown in a github branch: https://github.com/mesosphere/mesos/tree/defer_example/3rdparty/libprocess
> 
> Note that in addition to the inclusion of this example, further changes to the `defer`
documentation preceding the example are currently being considered: https://reviews.apache.org/r/41618/
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message