mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 41848: Do not enable task and executor run on different resources.
Date Thu, 07 Jan 2016 23:38:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41848/#review113354
-----------------------------------------------------------


Overall, the changes and tests LGTM.


src/master/validation.cpp (line 487)
<https://reviews.apache.org/r/41848/#comment173901>

    This is probably not necessary.
    
    Before you'd see:
    "Task (and its executor, if exists) uses both revocable and non-revocable cpus".
    
    With your change, it becomes:
    "Task (and its executor, if exists) uses both revocable and non-revocable cpus(*){USAGE_SLACK}:1".
    
    I prefer the first one.


- Joseph Wu


On Jan. 7, 2016, 3:26 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41848/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2016, 3:26 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph
Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-3931
>     https://issues.apache.org/jira/browse/MESOS-3931
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Do not enable task and its executor run on different resources. They
> must run on same kind of resources, either non-revocable resources, usage
> slack resources or allocation slack resources.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305 
>   src/tests/master_validation_tests.cpp fbf8fadbc04a7cbc60ee6091e0224339389b400f 
> 
> Diff: https://reviews.apache.org/r/41848/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message