mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 41782: Logger Module: Wire up the rotating container logger module and test.
Date Fri, 08 Jan 2016 00:43:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41782/#review113373
-----------------------------------------------------------



src/Makefile.am (line 1077)
<https://reviews.apache.org/r/41782/#comment173972>

    You should be able to fix the whitespace that review board is complaining about here,
ditto below.



src/tests/module.cpp (line 111)
<https://reviews.apache.org/r/41782/#comment173951>

    s/sandboxPath/sandboxDirectory/
    
    ?



src/tests/module.cpp (line 125)
<https://reviews.apache.org/r/41782/#comment173971>

    I'm confused by the name of the variable `truncatingPath` ... is this a remanant of the
old code and should be `rotatingContainerLoggerPath`?



src/tests/module.cpp (line 135)
<https://reviews.apache.org/r/41782/#comment173970>

    Interesting that you pulled it out as a constant in the previous review, but not here?



src/tests/module.cpp (line 143)
<https://reviews.apache.org/r/41782/#comment173952>

    .



src/tests/module.cpp (lines 152 - 154)
<https://reviews.apache.org/r/41782/#comment173954>

    Is this a dead flag?


- Benjamin Hindman


On Jan. 5, 2016, 2:21 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41782/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 2:21 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-4136
>     https://issues.apache.org/jira/browse/MESOS-4136
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Creates a new binary "mesos-rotate-logger" for use by the non-default "Rotating" ContainerLogger
module.
> Adds the `RotatingContainerLogger` to the test module configuration.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am e08e86724abaa3023f0483aa222354c95d4d3817 
>   src/tests/module.hpp 8e92774ddd51bc8a1368fb1cf6546300696b2d22 
>   src/tests/module.cpp 7968519996ca9f9d8895e73d5f173d26a7e794e0 
> 
> Diff: https://reviews.apache.org/r/41782/diff/
> 
> 
> Testing
> -------
> 
> Note: Some of the files added to the makefile are created in the next review.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message