mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guangya Liu" <gyliu...@gmail.com>
Subject Re: Review Request 41333: Added helper functions to filter usage slack resources.
Date Fri, 08 Jan 2016 01:18:37 GMT


> On 一月 6, 2016, 12:01 p.m., Klaus Ma wrote:
> > Overall comments is that: is this code called by any others? If not, why should
we add that? I'd suggest to add this on demand.
> 
> Joseph Wu wrote:
>     I agree.  If this is not used, we should not add it.
> 
> Guangya Liu wrote:
>     It is needed as the master need to make sure task and its executor do not run on
different resources. They must run on same kind of resources, either non-revocable resources,
usage slack resources or allocation slack resources.
> 
> Joseph Wu wrote:
>     Do we need that restriction?
>     
>     Tasks can currently run on normal resources + usage slack.  In this case, the `QoSController`
will kill both resource types if the usage slack is "corrected".  We decided on analogous
behavior for allocation slack.

The current implementation do not allow a task use both revocable and non-revocable resources
for a specified resource. i.e. a task can only use revocable or non-revocable cpu resources
but cannot both; A task can use revocable cpu and non-revocable memory resources. 

I udpated the validation here https://reviews.apache.org/r/41848/ by enhancing a task resource
cannot use non-revocable, usage slack and allocation slack resources.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41333/#review113053
-----------------------------------------------------------


On 一月 7, 2016, 7:40 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41333/
> -----------------------------------------------------------
> 
> (Updated 一月 7, 2016, 7:40 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph
Wu, and Klaus Ma.
> 
> 
> Bugs: MESOS-4146
>     https://issues.apache.org/jira/browse/MESOS-4146
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added helper functions to filter usage slack resources. This helper function will be
used to validate if the task is using usage slack resource or not so as to make sure that
one task or executor can only use same kind of resources.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp cc8fef9470d779078aa408ed03e747e5a492deaa 
>   include/mesos/v1/resources.hpp f4892977f8d7b0439db6e9cf7921334f606a496c 
>   src/common/resources.cpp 6afd2dfd81adecf7bdb3e523bc840efb62b79ef4 
>   src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320 
>   src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc 
> 
> Diff: https://reviews.apache.org/r/41333/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message