mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Toenshoff" <toensh...@me.com>
Subject Re: Review Request 39043: Added support for HTTP Authentication in Mesos.
Date Fri, 08 Jan 2016 03:01:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39043/#review113377
-----------------------------------------------------------


This looks ready Alexander. Let me fix most issues marked here while landing this patch. I
left them marked as unsolved for your consideration. Note that some of the below issues still
need you to take actions!


src/master/flags.cpp (lines 447 - 454)
<https://reviews.apache.org/r/39043/#comment173973>

    s/Authenticator/authenticator/g
    
    We need to update configuration.md with this - adding that to your patch while committing.



src/master/flags.cpp (line 454)
<https://reviews.apache.org/r/39043/#comment174002>

    s/thre's/there is/
    s/Authenticators/authenticators/
    
    We should consider making this remark for both, "old"- and http authenticators. In any
case, this should be made consistent. Please follow up, thanks!



src/master/master.cpp (lines 500 - 501)
<https://reviews.apache.org/r/39043/#comment174006>

    I believe we agreed to have a tracking JIRA for this one. Please create it, thanks Alexander!



src/master/master.cpp (line 501)
<https://reviews.apache.org/r/39043/#comment173996>

    s/Authenticator/authenticator/
    s/allocator/the allocator/



src/master/master.cpp (line 512)
<https://reviews.apache.org/r/39043/#comment173998>

    As the flag name suggests otherwise, we obviously intend to allow multiple authenticators
in the future. Can you please add a JIRA that captures this? Thanks Alexander!



src/master/master.cpp (line 517)
<https://reviews.apache.org/r/39043/#comment173997>

    s/HTTP Authenticator/HTTP authenticator/



src/master/master.cpp (line 528)
<https://reviews.apache.org/r/39043/#comment173987>

    s/.//



src/tests/mesos.cpp (line 436)
<https://reviews.apache.org/r/39043/#comment173989>

    As discussed and commented by Alex, that addition about the risks in multi-master configurations
are a good idea. Adding that while committing.


- Till Toenshoff


On Jan. 7, 2016, 4:41 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39043/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2016, 4:41 p.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, Jan Schlicht, and Till
Toenshoff.
> 
> 
> Bugs: MESOS-3756 and MESOS-4149
>     https://issues.apache.org/jira/browse/MESOS-3756
>     https://issues.apache.org/jira/browse/MESOS-4149
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> 1. Adds a flag to load an HTTP Authenticator module from the flags.
> 2. If provided, uses the credentials file to initialize the default HTTP Authenticator.
> 3. Updates the existing endpoints which implement their own basic HTTP authenticator
with the libprocess one.
> 4. Updates one test which expected the wrong results since now credentials are checked
before the body of the request.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authentication/http/basic_authenticator_factory.hpp PRE-CREATION 
>   src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION 
>   src/master/constants.hpp f1624e1ed5091f08f57d4382b344cab8b05ba840 
>   src/master/constants.cpp 589f2ee55a24d7e8b9352a4c8f94a3785fd1bef4 
>   src/master/flags.hpp 9af6c68eef6bcf39d5776809fab6c66dc95da6b2 
>   src/master/flags.cpp f864419a6276356c97a0a4fe29e5cfce6c4660c4 
>   src/master/http.cpp d7afa2af989eebfc9039b3681f087ce570f601d5 
>   src/master/master.hpp f764915ff8bbf74b99a617e3c4735d38fc13e5f0 
>   src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
>   src/master/quota_handler.cpp 93960f3728f9e68c085e6009fe975542d29d2551 
>   src/tests/master_quota_tests.cpp bc8a117982b994279e0df7639b21abaeb308b76d 
>   src/tests/mesos.cpp 3867ed2fcb197f98f0a19ca37ed81392db27e8a0 
> 
> Diff: https://reviews.apache.org/r/39043/diff/
> 
> 
> Testing
> -------
> 
> ```bash
> # On OS X 10.11.2 and Ubuntu 14.04.3
> $ make check
> $ ./bin/mesos-tests.sh --gtest_repeat=50 --gtest_shuffle --gtest_break_on_failure
> 
> # On Ubuntu 14.04.3 (Disabling known flaky tests)
> $ sudo ./bin/mesos-tests.sh --gtest_repeat=50 --gtest_shuffle --gtest_break_on_failure
\
>     --gtest_filter="-*.ROOT_IncreaseRSS:*.ROOT_CGROUPS_Listen"
> ```
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message