mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.
Date Sat, 09 Jan 2016 00:42:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/#review113576
-----------------------------------------------------------

Ship it!


Regarding the snake_case, my comment was regarding the function and variable names, eg. `pathSize`
-> `path_size`


3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp (lines 61 - 62)
<https://reviews.apache.org/r/39019/#comment174318>

    I don't see the check for pathSize wrt. MAX_PATH.



3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp (lines 193 -
199)
<https://reviews.apache.org/r/39019/#comment174313>

    `free` is meant to be safe for `NULL/nullptr`.
    Why not follow this pattern?
    asserting `directory != NULL` seems like it might surprise people?



3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp (line 204)
<https://reviews.apache.org/r/39019/#comment174315>

    why assert vs. false with errno?



3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp (line 214)
<https://reviews.apache.org/r/39019/#comment174317>

    are `null-terminated` right?
    Same for the commeint in `_reentrantAdvanceDirStream`



3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp (line 226)
<https://reviews.apache.org/r/39019/#comment174316>

    same question as above.


- Joris Van Remoortere


On Dec. 23, 2015, 6:44 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39019/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2015, 6:44 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere,
and Joseph Wu.
> 
> 
> Bugs: MESOS-3441
>     https://issues.apache.org/jira/browse/MESOS-3441
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Added dirent compat code for non-Unix systems.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe

>   3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp PRE-CREATION

>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp d46e262e0fd1c2de36f3bf19d8bd693c23bf58cd

> 
> Diff: https://reviews.apache.org/r/39019/diff/
> 
> 
> Testing
> -------
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message