mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 41781: Add test for behavior of the rotating container logger module.
Date Sat, 16 Jan 2016 00:54:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41781/
-----------------------------------------------------------

(Updated Jan. 15, 2016, 4:54 p.m.)


Review request for mesos, Benjamin Hindman and Artem Harutyunyan.


Changes
-------

* Add new test to `LOGROTATE_` test filter.
* Fix some flakiness (cleanup of subprocesses) in the test.
* Change expectations inside test to match the default behavior of `logrotate`.


Summary (updated)
-----------------

Add test for behavior of the rotating container logger module.


Bugs: MESOS-4136
    https://issues.apache.org/jira/browse/MESOS-4136


Repository: mesos


Description (updated)
-------

Add test for behavior of the rotating container logger module.


Diffs (updated)
-----

  src/tests/container_logger_tests.cpp c6b2e597517c74a55649287dc5ae5a3115f9a640 

Diff: https://reviews.apache.org/r/41781/diff/


Testing
-------

This test is run later in the review chain.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message