mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guangya Liu" <gyliu...@gmail.com>
Subject Re: Review Request 42123: Enabled load qos controller use USAGE SLACK revocable resources.
Date Sat, 16 Jan 2016 08:00:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42123/
-----------------------------------------------------------

(Updated 一月 16, 2016, 8 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu,
Klaus Ma, and Jian Qiu.


Changes
-------

Updated unit test.


Bugs: MESOS-4322
    https://issues.apache.org/jira/browse/MESOS-4322


Repository: mesos


Description
-------

The current load qos controller is calculating executor used
resources via revocable() API, but this is not right as the
revocable() will include both USAGE SLACK and ALLOCATION SLACK.

This patch is updating the load qos controller only get USAGE
SLACK revocable resources for executors.

The unit test was already covered in oversubscription_tests.cpp.


Diffs (updated)
-----

  src/slave/qos_controllers/load.cpp 52520d6220784423c09001b8bd59e090ebf787ec 
  src/tests/oversubscription_tests.cpp 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a 

Diff: https://reviews.apache.org/r/42123/diff/


Testing
-------

make
make check


Thanks,

Guangya Liu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message