mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Mann" <g...@mesosphere.io>
Subject Re: Review Request 42334: Changed 'ReservationInfo.principal' from required to optional.
Date Sat, 16 Jan 2016 16:30:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42334/
-----------------------------------------------------------

(Updated Jan. 16, 2016, 4:30 p.m.)


Review request for mesos, Jie Yu, Michael Park, and Vinod Kone.


Changes
-------

Addressed comments.


Bugs: MESOS-4382
    https://issues.apache.org/jira/browse/MESOS-4382


Repository: mesos


Description
-------

Changed `ReservationInfo.principal` from required to optional.

In order to allow dynamic reservation without a principal, this field is being changed to
optional. However, the current patch alters the master to invalidate any reserve operations
that do not set this field. After a deprecation cycle, the master will allow the field to
be unset.


Diffs (updated)
-----

  include/mesos/mesos.proto b12e0f3eff44d90ec01360fc08bf9e597d7ed9dd 
  include/mesos/v1/mesos.proto fa7e82e03b11cf6619a4f16e8e0fbbf755bf210c 
  src/master/validation.cpp c7cf56815fc743ff52ef423b23d78398ad1b35a3 
  src/tests/master_validation_tests.cpp fbf8fadbc04a7cbc60ee6091e0224339389b400f 

Diff: https://reviews.apache.org/r/42334/diff/


Testing
-------

A new test was added, `ReserveOperationValidationTest.ReservationInfoMissingPrincipal`, within
the master validation tests, to ensure that a `ReservationInfo` with no principal will be
invalidated.

`make check` was used to test.


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message