mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 42390: Fixed fetching uris when slave is running inside a container.
Date Sat, 16 Jan 2016 17:01:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42390/#review114869
-----------------------------------------------------------


Patch looks great!

Reviews applied: [42390]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc;
./support/docker_build.sh

- Mesos ReviewBot


On Jan. 16, 2016, 3:59 p.m., Shuai Lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42390/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2016, 3:59 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-4249
>     https://issues.apache.org/jira/browse/MESOS-4249
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This still requires the slave work dir is a mounted volume, otherwise the slave has no
way to fetch into the task container's sandbox.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp da19975c1f1e59fab0a96ebd9aa815bba2a35ece 
> 
> Diff: https://reviews.apache.org/r/42390/diff/
> 
> 
> Testing
> -------
> 
> - Start a master, then start the slave inside a docker container, with the work_dir being
a mounted volume
> - Start a simple framework, which, on receiving the first offer, launches a task with
a uri in the command info
> - When the task container is launched, check the file is fetched into the sandbox
> ```sh
> $ docker exec <task-container-id> ls /mnt/mesos/sandbox
> robots.txt
> stderr
> stdout
> ```
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message