mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Qian Zhang" <zhang...@cn.ibm.com>
Subject Re: Review Request 42068: Porting 3rdparty on ppc64le.
Date Wed, 20 Jan 2016 12:49:45 GMT


> On Jan. 18, 2016, 2:37 a.m., Artem Harutyunyan wrote:
> > We avoid making changes in 3rdparty and the Mesos code within the same patch. Could
you please break this patch into 2?
> 
> Qian Zhang wrote:
>     Did you mean splitting the commit between mesos and libprocess? I saw we have a check
in the pre-commit (see the link below) which ensures we should not have the code changes for
Mesos and libprocess in the same patch, that's why I have two commit: this one and https://reviews.apache.org/r/42069/,
please let me know if you have further comments.
>     https://github.com/apache/mesos/blob/0.26.0/support/hooks/pre-commit#L29
> 
> Joseph Wu wrote:
>     There's isn't a pre-commit hook for everything in 3rdparty, but it would be good
to separate:
>     3rdparty/leveldb.patch
>     3rdparty/zookeeper-3.4.5.patch
>     
>     ---
>     
>     src/linux/fs.cpp

OK, I have updated this one to only contain 3rdparty, and upload a new patch (https://reviews.apache.org/r/42551/)
for Mesos code change.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42068/#review114910
-----------------------------------------------------------


On Jan. 20, 2016, 8:38 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42068/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2016, 8:38 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4312
>     https://issues.apache.org/jira/browse/MESOS-4312
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Porting 3rdparty on ppc64le.
> 
> 
> Diffs
> -----
> 
>   3rdparty/leveldb.patch ad8c19b9caa856ff85978ba832d48df11b3a83f0 
>   3rdparty/zookeeper-3.4.5.patch 3ca180d0c81f5de521ada7fb6c1c248a871ab2da 
> 
> Diff: https://reviews.apache.org/r/42068/diff/
> 
> 
> Testing
> -------
> 
> make check (OSX 10.10.5, Ubuntu 14.04.3 LTS ppc64le)
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message