mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 42557: Moved CachedImage to a separate file.
Date Wed, 20 Jan 2016 19:44:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42557/#review115465
-----------------------------------------------------------


Bad patch!

Reviews applied: [41958, 41959, 42156, 42157]

Failed command: ./support/apply-review.sh -n -r 42157

Error:
 2016-01-20 19:44:16 URL:https://reviews.apache.org/r/42157/diff/raw/ [3978/3978] -> "42157.patch"
[1]
error: patch failed: src/tests/containerizer/provisioner_appc_tests.cpp:253
error: src/tests/containerizer/provisioner_appc_tests.cpp: patch does not apply

- Mesos ReviewBot


On Jan. 20, 2016, 4:16 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42557/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2016, 4:16 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Currently CachedImage is private to the appc store. This will change as we
> implement image fetchers (eg. simple discovery).
> 
> This change will enable image fetcher to use the same structure.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 39a23df3227a4f524ea0d408dc894fa5bbab7d10 
>   src/Makefile.am 8cbfb1ba5fa49f2d3cc26ea325838a1c68a79660 
>   src/slave/containerizer/mesos/provisioner/appc/image_cache.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/appc/image_cache.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 73c4df858a70da3d4cc4a1cb15092165f6ff8fe4

> 
> Diff: https://reviews.apache.org/r/42557/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message