mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 42473: Multiple Disk: Updated filesystem isolators to use 'DiskInfo.Source'.
Date Wed, 20 Jan 2016 20:00:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42473/#review115471
-----------------------------------------------------------

Ship it!



src/slave/containerizer/mesos/isolators/filesystem/linux.cpp (lines 618 - 621)
<https://reviews.apache.org/r/42473/#comment176446>

    Can we use CHECK here instead. I think we already validate this master.



src/slave/containerizer/mesos/isolators/filesystem/posix.cpp (lines 192 - 195)
<https://reviews.apache.org/r/42473/#comment176447>

    Ditto.


- Jie Yu


On Jan. 20, 2016, 7:15 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42473/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2016, 7:15 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Michael Park.
> 
> 
> Bugs: MESOS-4402
>     https://issues.apache.org/jira/browse/MESOS-4402
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Multiple Disk: Updated filesystem isolators to use 'DiskInfo.Source'.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp ace9e305c24a9841f1716c9bf40cd13b16ef0cec

>   src/slave/containerizer/mesos/isolators/filesystem/posix.cpp d914587eedc9c66bc14b4088ec211b7f0eea63ea

> 
> Diff: https://reviews.apache.org/r/42473/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message