mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 41850: Add map to trace evictable executors.
Date Wed, 20 Jan 2016 23:17:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41850/#review115295
-----------------------------------------------------------



src/slave/slave.cpp (line 1599)
<https://reviews.apache.org/r/41850/#comment176261>

    The way you're using this helper suggests that all executors are evictable (which they
are not).
    
    If you only use the helpers once, it may be better to put the logic in here directly.
    Similar for `removeEvictableExecutor`.


- Joseph Wu


On Jan. 7, 2016, 10:53 p.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41850/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2016, 10:53 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van Remoortere,
Joseph Wu, and Jian Qiu.
> 
> 
> Bugs: MESOS-3892
>     https://issues.apache.org/jira/browse/MESOS-3892
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Before getting evictable executors for evicting, it need to trace which execuotor can
be evicted.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
>   src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c 
> 
> Diff: https://reviews.apache.org/r/41850/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message