mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yongqiao Wang <yq...@cn.ibm.com>
Subject Re: Review Request 43824: Addressed comments of 41672.
Date Tue, 01 Mar 2016 06:13:36 GMT


> On Feb. 28, 2016, 9:39 a.m., Adam B wrote:
> > src/tests/hierarchical_allocator_tests.cpp, lines 2658-2661
> > <https://reviews.apache.org/r/43824/diff/1/?file=1264015#file1264015line2658>
> >
> >     Can you say 100% and 0% instead of 1 and 0? And how is framework1's "share"
'6'? Is that the number of agents/offers, rather than the framework's "share"?

I refer to the styles in above tests in this file? for example: https://github.com/apache/mesos/blob/master/src/tests/hierarchical_allocator_tests.cpp?262#L262
so I used 1 rather than 100%. I think we should keep consistent, especially in a same file.
For framework's "share", I have updated them to a ratio.


- Yongqiao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43824/#review121132
-----------------------------------------------------------


On Feb. 22, 2016, 7:23 a.m., Yongqiao Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43824/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2016, 7:23 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-4200
>     https://issues.apache.org/jira/browse/MESOS-4200
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Addressed comments of 41672.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp 5f771f02db9bd098f3cd36730cd84bf2f5e87a33

> 
> Diff: https://reviews.apache.org/r/43824/diff/
> 
> 
> Testing
> -------
> 
> make && make check successfully.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message