mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.
Date Tue, 01 Mar 2016 11:48:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43880/#review121405
-----------------------------------------------------------




docs/monitoring.md (lines 881 - 883)
<https://reviews.apache.org/r/43880/#comment183105>

    Same question as in the previous review: does it make sense to put them all on the same
line?



src/master/allocator/mesos/hierarchical.hpp (lines 283 - 284)
<https://reviews.apache.org/r/43880/#comment183106>

    Blank line, please!
    
    We usually separate loops with blank lines from the surrounding code, except when it tightly
related to the loop, which is not the case here, right?



src/master/allocator/mesos/hierarchical.cpp (line 402)
<https://reviews.apache.org/r/43880/#comment183092>

    Can we factor this out to a separate file? I would like to keep this file as small and
readable as possible.



src/tests/hierarchical_allocator_tests.cpp (line 2406)
<https://reviews.apache.org/r/43880/#comment183081>

    I believe the actual value in JSON is double, right?



src/tests/hierarchical_allocator_tests.cpp (lines 2419 - 2420)
<https://reviews.apache.org/r/43880/#comment183110>

    Let's insert a blank line here or make the comment trailing.



src/tests/hierarchical_allocator_tests.cpp (line 2423)
<https://reviews.apache.org/r/43880/#comment183108>

    Don't forget to backtick variables! Here it's `agent1`.



src/tests/hierarchical_allocator_tests.cpp (lines 2445 - 2446)
<https://reviews.apache.org/r/43880/#comment183111>

    How it is different to the previous block?



src/tests/hierarchical_allocator_tests.cpp (line 2476)
<https://reviews.apache.org/r/43880/#comment183112>

    Why this math?


- Alexander Rukletsov


On Feb. 28, 2016, 9:28 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43880/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2016, 9:28 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4720
>     https://issues.apache.org/jira/browse/MESOS-4720
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added allocator metrics for total and allocated scalar resources.
> 
> 
> Diffs
> -----
> 
>   docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 
>   src/master/allocator/mesos/hierarchical.hpp 3043888630b066505410d3b32c5b3f813cc458c1

>   src/master/allocator/mesos/hierarchical.cpp 24fa50f62dec10ed43089297473cc386d6ba2f78

>   src/tests/hierarchical_allocator_tests.cpp 5f771f02db9bd098f3cd36730cd84bf2f5e87a33

> 
> Diff: https://reviews.apache.org/r/43880/diff/
> 
> 
> Testing
> -------
> 
> make check (OS X)
> 
> I confirmed that this does not lead to general performance regressions in the allocator;
this is partially expected since the added code only inserts metrics in the allocator while
the actual work is perform asynchronously. These tests where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers`
on an optimized build under OS X using clang(trunk) as compiler.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message