mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 44221: Added runtime isolator check if docker is image provider.
Date Tue, 01 Mar 2016 19:52:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44221/#review121479
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/provisioner/store.cpp (lines 45 - 52)
<https://reviews.apache.org/r/44221/#comment183188>

    I would put this check AFTER 'stores' are constructed below. In that way, you don't have
to use flags.image_providers any more.


- Jie Yu


On March 1, 2016, 7:50 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44221/
> -----------------------------------------------------------
> 
> (Updated March 1, 2016, 7:50 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4830
>     https://issues.apache.org/jira/browse/MESOS-4830
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added runtime isolator check if docker is image provider.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/store.cpp 40bc00c7027d29d75a313edfe2c61a2756c546ae

> 
> Diff: https://reviews.apache.org/r/44221/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> Tested with master and slave up.
> 
> ./bin/mesos-slave.sh --master=127.0.0.1:5050 --work_dir=/tmp --image_providers=DOCKER
--launcher=linux --isolation=filesystem/linux
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message