mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 44189: Document docker runtime isolator.
Date Tue, 01 Mar 2016 20:00:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44189/#review121478
-----------------------------------------------------------




docs/mesos-containerizer.md (lines 89 - 92)
<https://reviews.apache.org/r/44189/#comment183184>

    We should mention that this isolator is tied with --image_providers=docker. If --image_proviers
contains 'docker', the isolator must be used. Otherwise, slave will refuse to start.
    
    And then, you can mention that this isolator is used for supporting runtime configurations
from the docker image (e.g., entrypoint/cmd, env, etc.)



docs/mesos-containerizer.md (lines 96 - 97)
<https://reviews.apache.org/r/44189/#comment183186>

    I would say:
    ```
    Users can specify `CommandInfo` to override the default `Entrypoint` and `Cmd` in the
image (see below for details).
    ```



docs/mesos-containerizer.md (line 99)
<https://reviews.apache.org/r/44189/#comment183185>

    s/executor/task/



docs/mesos-containerizer.md (line 101)
<https://reviews.apache.org/r/44189/#comment183187>

    I would add a subtitle for this:
    ```
    Determine the launch command
    ```



docs/mesos-containerizer.md (lines 103 - 104)
<https://reviews.apache.org/r/44189/#comment183189>

    to determine what will be the launch command, ...
    
    kill `It is straightfoward ...`



docs/mesos-containerizer.md (line 105)
<https://reviews.apache.org/r/44189/#comment183194>

    I would add a paragraph here to explain the overall flow how we determine the launch command:
    ```
    If user specifies a command in CommandInfo, that will override the default entrypoint/cmd
in the docker image. Otherwise, we'll use the default entrypoint/cmd and append arguments
specified in CommandInfo accordingly. The details are explained in the following table.
    ```



docs/mesos-containerizer.md (line 106)
<https://reviews.apache.org/r/44189/#comment183190>

    User can specify `CommandInfo` including `shell`, `value` and `arguments`, which are represented
...



docs/mesos-containerizer.md (line 109)
<https://reviews.apache.org/r/44189/#comment183191>

    s/defined/specified/



docs/mesos-containerizer.md (line 110)
<https://reviews.apache.org/r/44189/#comment183193>

    s/default configuration//



docs/mesos-containerizer.md (lines 115 - 128)
<https://reviews.apache.org/r/44189/#comment183195>

    I would kill this in favor of using the paragraph I mentioned above.


- Jie Yu


On March 1, 2016, 12:03 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44189/
> -----------------------------------------------------------
> 
> (Updated March 1, 2016, 12:03 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, Neil Conway, and Timothy Chen.
> 
> 
> Bugs: MESOS-4683
>     https://issues.apache.org/jira/browse/MESOS-4683
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Document docker runtime isolator.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-containerizer.md 5edfbc3af3a3233cf9ab651290c298e8b6b77890 
> 
> Diff: https://reviews.apache.org/r/44189/diff/
> 
> 
> Testing
> -------
> 
> Tested with support/site-docker. Verified that the table works correctly.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message