mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 44164: Improved debug ability for docker puller.
Date Tue, 01 Mar 2016 22:43:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44164/#review121526
-----------------------------------------------------------


Fix it, then Ship it!




This is great! Thanks! I'll address the issue for you and commit. I think it's useful to get
this in before 0.28.


src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp (line 148)
<https://reviews.apache.org/r/44164/#comment183242>

    This does not seem to be necessary. Can you remove it.



src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp (line 151)
<https://reviews.apache.org/r/44164/#comment183243>

    I won't mentioned 'storedImagePath' because it's static.



src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp (line 170)
<https://reviews.apache.org/r/44164/#comment183244>

    Ditto.



src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp (line 243)
<https://reviews.apache.org/r/44164/#comment183246>

    s/in recovery//g


- Jie Yu


On Feb. 29, 2016, 3:55 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44164/
> -----------------------------------------------------------
> 
> (Updated Feb. 29, 2016, 3:55 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4796
>     https://issues.apache.org/jira/browse/MESOS-4796
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Improved debug ability for docker puller.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp ea4c2fff14a271e1e9c514d151407a5d8785e2a4

>   src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp f391a943551792c8edf5759d9491fda33116f2b4

>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 3fd58f61a6daa3e03bd79931947084c50b1b80d4

> 
> Diff: https://reviews.apache.org/r/44164/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> Tested with both local puller and registery puller, all related logs can be logged.
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message