mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Mahler <benjamin.mah...@gmail.com>
Subject Re: Review Request 44073: Disabled metrics endpoint rate limiting in mesos tests.
Date Thu, 03 Mar 2016 05:31:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44073/#review121780
-----------------------------------------------------------



This patch should also remove any remnants of advancing the clock to deal with metrics rate
limiting, I'll go ahead and do that for you before committing.


src/tests/main.cpp (line 28)
<https://reviews.apache.org/r/44073/#comment183618>

    We need to include the os agnostic version here, otherwise this doesn't work for windows.



src/tests/main.cpp (lines 75 - 77)
<https://reviews.apache.org/r/44073/#comment183631>

    This means we need to update the tests to remove any clock advances to cope with the rate
limiting.


- Ben Mahler


On March 1, 2016, 4:28 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44073/
> -----------------------------------------------------------
> 
> (Updated March 1, 2016, 4:28 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Ben Mahler.
> 
> 
> Bugs: MESOS-4783
>     https://issues.apache.org/jira/browse/MESOS-4783
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Disabled metrics endpoint rate limiting in mesos tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/main.cpp 942488e57419ace8b7a821f53024aced0f43c7d9 
> 
> Diff: https://reviews.apache.org/r/44073/diff/
> 
> 
> Testing
> -------
> 
> make distcheck (ubuntu 12 & 14), make check (OS X)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message