mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 43824: Addressed comments of 41672.
Date Thu, 03 Mar 2016 13:47:09 GMT


> On March 3, 2016, 9:03 a.m., Alexander Rukletsov wrote:
> > src/tests/hierarchical_allocator_tests.cpp, lines 2635-2640
> > <https://reviews.apache.org/r/43824/diff/2/?file=1275001#file1275001line2635>
> >
> >     Does it fit one line? I know we are a bit inconsistent about it, but let's prefer
oneliners where it doesn't impact the readability.
> 
> Yongqiao Wang wrote:
>     Put those parameters into one line will exceed 80 chars, then `git commit` will failed
due to the default check. I agree with your suggestion, but I think we should have a discussion
in community to enhance the related check rules.

How come `allocator->addSlave(agent.id(), agent, None(), agent.resources(), {});` does
not fit in 80 chars, even prefixed with 4 spaces?


> On March 3, 2016, 9:03 a.m., Alexander Rukletsov wrote:
> > src/tests/hierarchical_allocator_tests.cpp, lines 2736-2738
> > <https://reviews.apache.org/r/43824/diff/2/?file=1275001#file1275001line2736>
> >
> >     I think these lines are good candidate to go under the `{}` together with the
checks. This way you can avoid numeral suffixes and have a 1:1 relation between `{}`-blocks
and test cases.
> >     
> >     Does it make sense?
> 
> Yongqiao Wang wrote:
>     Update weights should be a completely different logic with the above check, so it
would not be proper to put them together.

I'm talking about the checks *below*, those, where you observe the effect of setting weights.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43824/#review121642
-----------------------------------------------------------


On March 3, 2016, 1:28 p.m., Yongqiao Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43824/
> -----------------------------------------------------------
> 
> (Updated March 3, 2016, 1:28 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-4200
>     https://issues.apache.org/jira/browse/MESOS-4200
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Addressed comments of 41672.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp 3e4ad31925e1b815a74d67fa3962d23fa5bc89d1

> 
> Diff: https://reviews.apache.org/r/43824/diff/
> 
> 
> Testing
> -------
> 
> make && make check successfully.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message