mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 44200: Add agent flags for specifying CNI plugin and config directories.
Date Fri, 04 Mar 2016 01:46:48 GMT


> On March 2, 2016, 1:03 a.m., Gilbert Song wrote:
> > src/slave/flags.cpp, lines 698-705
> > <https://reviews.apache.org/r/44200/diff/1/?file=1275006#file1275006line698>
> >
> >     While users can config the CNI network form a JSON file, is it possible to provide
an option to define the CNI config from cli?
> 
> Qian Zhang wrote:
>     Yes, I think it is possible and there are already a couple of flags defined in this
way, e.g., `--resources`, `--credential`. @Jie, do you think we should switch to this way?
> 
> Avinash sridharan wrote:
>     I think this question was raised during the design review. Jie had mentioned its
a bit of a pain to parse JSON config from command line and doesn't add any functional value
to the MVP at this point. Its just semanitc sugar that can be done later.

OK, then let's stick on the original design.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44200/#review121445
-----------------------------------------------------------


On March 1, 2016, 3:04 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44200/
> -----------------------------------------------------------
> 
> (Updated March 1, 2016, 3:04 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4761
>     https://issues.apache.org/jira/browse/MESOS-4761
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add agent flags for specifying CNI plugin and config directories.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md c4d094aac4acb95fd6648071413a3d5160dbf381 
>   docs/endpoints/slave/state.json.md a6403eea3426bdec81d170d0829ffe7174862e55 
>   docs/endpoints/slave/state.md bdd555e0231935c668dea1ba63582348db2b3629 
>   src/slave/flags.hpp c07932157ffe36ea36f1def4c7d92b79d2219c48 
>   src/slave/flags.cpp 7f139e99e8392fe95bb30070896ed9d95dfe5701 
>   src/slave/http.cpp 4eb1fafdfa72094511b0b2684a3c2705bd8c7c5e 
> 
> Diff: https://reviews.apache.org/r/44200/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message