mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 44200: Add agent flags for specifying CNI plugin and config directories.
Date Fri, 04 Mar 2016 14:45:27 GMT


> On March 2, 2016, 4:07 p.m., Avinash sridharan wrote:
> > src/slave/flags.cpp, line 694
> > <https://reviews.apache.org/r/44200/diff/1/?file=1275006#file1275006line694>
> >
> >     s/directory/location
> >     
> >     remove this line:
> >     This flag is used for\n"
> >           "the `network/cni` isolator.\n",
> >           "/tmp/mesos/cni/plugins"
> 
> Qian Zhang wrote:
>     Did you mean removing the line: `This flag is used for the 'network/cni' isolator.`?
I think this is the existing convention, please see the help message of `Flags::eth0_name`,
`Flags::network_enable_snmp_statistics`, `Flags::container_disk_watch_interval`, etc. They
all have the line like: `This flag is used for the 'xxx' isolator.`.
> 
> Avinash sridharan wrote:
>     Not sure what you mean by convention in help strings? The sentence is redundant (doesn't
given any more information than the previous sentences). Lets use the correct form here. 
Help strings should be concise.
> 
> Qian Zhang wrote:
>     What I mean by convention in help strings is, if a flag is specific to an isolator,
then we should mention that in the help strings of that flag, please see the following code
for an example (and there are more in agent's flags):
>     https://github.com/apache/mesos/blob/0.27.1/src/slave/flags.cpp#L586:L587
>     
>     So your comment is that I should remove the line `This flag is used for the 'network/cni'
isolator.` from the help strings of both `Flags::network_cni_plugins_dir` and `Flags::network_cni_config_dir`?

Yup. Just remove that line.


- Avinash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44200/#review121661
-----------------------------------------------------------


On March 4, 2016, 2:36 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44200/
> -----------------------------------------------------------
> 
> (Updated March 4, 2016, 2:36 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4761
>     https://issues.apache.org/jira/browse/MESOS-4761
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add agent flags for specifying CNI plugin and config directories.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
>   src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 
>   src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 
> 
> Diff: https://reviews.apache.org/r/44200/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message