mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 44414: Added documentation about container image support.
Date Sun, 06 Mar 2016 04:35:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44414/#review122221
-----------------------------------------------------------




docs/container-image.md (lines 146 - 177)
<https://reviews.apache.org/r/44414/#comment184135>

    What about move this to `## Docker Support`



docs/container-image.md (lines 216 - 220)
<https://reviews.apache.org/r/44414/#comment184134>

    Suggest add the default value here: https://registry-1.docker.io
    
    s/The default URL/The URL



docs/container-image.md (lines 222 - 223)
<https://reviews.apache.org/r/44414/#comment184133>

    Suggest add the default value here: /tmp/mesos/store/docker



docs/container-image.md (lines 228 - 237)
<https://reviews.apache.org/r/44414/#comment184136>

    Can you please add some command line as Docker for how to test this out?



docs/container-image.md (line 241)
<https://reviews.apache.org/r/44414/#comment184137>

    Suggest add the default value here: http://



docs/container-image.md (line 245)
<https://reviews.apache.org/r/44414/#comment184138>

    Suggest add the default value here: /tmp/mesos/store/appc



docs/container-image.md (line 253)
<https://reviews.apache.org/r/44414/#comment184139>

    move this word above?



docs/container-image.md (lines 273 - 279)
<https://reviews.apache.org/r/44414/#comment184140>

    I filed an issue for this read-only mount point https://issues.apache.org/jira/browse/MESOS-4876
, so with a `bind` backend, the end user need to make sure that the `sandbox_directory` must
already exist for the rootfs. By defult, the docker images will not include a default sandbox
as `/mnt/mesos/sandbox`, the task will always be failed. Shall we highlight that it is better
to specify an existing sandbox when start agent?


- Guangya Liu


On 三月 5, 2016, 2:20 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44414/
> -----------------------------------------------------------
> 
> (Updated 三月 5, 2016, 2:20 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jojy Varghese, Neil Conway, Timothy Chen, and
Vinod Kone.
> 
> 
> Bugs: MESOS-4873
>     https://issues.apache.org/jira/browse/MESOS-4873
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added documentation about container image support.
> 
> 
> Diffs
> -----
> 
>   docs/container-image.md PRE-CREATION 
>   docs/mesos-provisioner.md 1b19406cb93bbc3f5330eaf9d29b1be98a674136 
> 
> Diff: https://reviews.apache.org/r/44414/diff/
> 
> 
> Testing
> -------
> 
> Tested the formatting in Mou
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message