mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam B <a...@mesosphere.io>
Subject Re: Review Request 43824: Addressed comments of 41672.
Date Tue, 08 Mar 2016 10:13:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43824/#review122494
-----------------------------------------------------------


Fix it, then Ship it!




Just a bunch a grammar fixes. Otherwise shippable.


src/tests/hierarchical_allocator_tests.cpp (line 2445)
<https://reviews.apache.org/r/43824/#comment184528>

    s/all/each/
    s/half of resources/half of the resources/



src/tests/hierarchical_allocator_tests.cpp (line 2446)
<https://reviews.apache.org/r/43824/#comment184529>

    s/role's weight/roles' weights/



src/tests/hierarchical_allocator_tests.cpp (line 2458)
<https://reviews.apache.org/r/43824/#comment184531>

    s/due to/since/



src/tests/hierarchical_allocator_tests.cpp (line 2490)
<https://reviews.apache.org/r/43824/#comment184533>

    s/,/;/



src/tests/hierarchical_allocator_tests.cpp (lines 2495 - 2496)
<https://reviews.apache.org/r/43824/#comment184534>

    s|the 1/3 resources|1/3 of the resources|
    s|the 2/3 resources|2/3 of the resources|



src/tests/hierarchical_allocator_tests.cpp (line 2496)
<https://reviews.apache.org/r/43824/#comment184535>

    s/role's weight/roles' weights/



src/tests/hierarchical_allocator_tests.cpp (line 2516)
<https://reviews.apache.org/r/43824/#comment184538>

    Seems like we repeat the contents of this loop a few times. Could all/part of the contents
be worth factoring out into a reusable helper function?



src/tests/hierarchical_allocator_tests.cpp (line 2545)
<https://reviews.apache.org/r/43824/#comment184539>

    s/,/;/



src/tests/hierarchical_allocator_tests.cpp (lines 2550 - 2551)
<https://reviews.apache.org/r/43824/#comment184541>

    s|the X/6 resources|X/6 of the resources|g



src/tests/hierarchical_allocator_tests.cpp (line 2552)
<https://reviews.apache.org/r/43824/#comment184542>

    s/role's weight/roles' weights/g



src/tests/hierarchical_allocator_tests.cpp (line 2559)
<https://reviews.apache.org/r/43824/#comment184543>

    s/due to/because/



src/tests/hierarchical_allocator_tests.cpp (line 2605)
<https://reviews.apache.org/r/43824/#comment184544>

    s/,/;/


- Adam B


On March 7, 2016, 5:55 a.m., Yongqiao Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43824/
> -----------------------------------------------------------
> 
> (Updated March 7, 2016, 5:55 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-4200
>     https://issues.apache.org/jira/browse/MESOS-4200
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Addressed comments of 41672.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp 3e4ad31925e1b815a74d67fa3962d23fa5bc89d1

> 
> Diff: https://reviews.apache.org/r/43824/diff/
> 
> 
> Testing
> -------
> 
> make && make check successfully.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message