mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 44269: Added the framework of 'network/cni' isolator.
Date Wed, 09 Mar 2016 06:03:05 GMT


> On March 9, 2016, 2:09 a.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/network/cni.cpp, lines 95-288
> > <https://reviews.apache.org/r/44269/diff/7/?file=1291677#file1291677line95>
> >
> >     I would strongly recommend move all `parse` and `validation` operations to `spec.cpp`,
because we may not want the `create` method to be that long.

I agree with you. However after discussed with Jie and Avinash, we all agree that we do not
need to valid the fields in the CNI network configuration file since the CNI plugin will do
the validation when "network/cni" isolator invokes it. So I removed all those field validation
code from `create()` method which makes it much shorter. Please see https://reviews.apache.org/r/44555/
for details and let me know if you have further comments :-)


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44269/#review122546
-----------------------------------------------------------


On March 8, 2016, 10:42 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44269/
> -----------------------------------------------------------
> 
> (Updated March 8, 2016, 10:42 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
>     https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the framework of 'network/cni' isolator.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 8f57a5701073bf1eaaa223383e928cf5db8f8ae4 
>   src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 
>   src/slave/containerizer/mesos/isolators/network/cni.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/cni.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/spec.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/spec.proto PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44269/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message